Bug 14445 - [CAIRO] GraphicsContextCairo code style cleanup
: [CAIRO] GraphicsContextCairo code style cleanup
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 523.x (Safari 3)
: All All
: P2 Normal
Assigned To: Nobody
Depends on:
  Show dependency treegraph
Reported: 2007-06-28 07:39 PDT by Alp Toker
Modified: 2007-07-05 06:49 PDT (History)
0 users

See Also:

GraphicsContextCairo code style cleanup (22.28 KB, patch)
2007-06-28 07:52 PDT, Alp Toker
no flags Details | Formatted Diff | Diff
Cairo backend code style cleanup (27.05 KB, patch)
2007-07-04 06:07 PDT, Alp Toker
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-06-28 07:39:03 PDT
GraphicsContextCairo.cpp could do with a cleanup.
Comment 1 Alp Toker 2007-06-28 07:52:29 PDT
Created attachment 15292 [details]
GraphicsContextCairo code style cleanup
Comment 2 Alp Toker 2007-07-04 06:07:41 PDT
Created attachment 15384 [details]
Cairo backend code style cleanup

This patch extends the previous one to cover more of the Cairo backend.
Comment 3 Holger Freyther 2007-07-05 01:29:14 PDT
The question on IRC was why do we want to name it 'cr'? What does cr mean?

The answers were:
    -We don't know what cr means but you can go from 'cairo_t' with finite steps to cr by removoing charachters.
    -Using 'context' for GraphicsContext and another name for the cairo_t handle seems natural
    -'cr' follows the habbit of cairo and Gtk+ and should be understandable by everyone having looked at cairo/Gdk/Gtk+.

Please apply this bugfix and cleanup (adding save/restore).

Comment 4 Mark Rowe (bdash) 2007-07-05 05:55:39 PDT
Comment on attachment 15384 [details]
Cairo backend code style cleanup

Looks reasonable enough.  I'm not particularly fond of the name "cr" but it does bring some consistency to the naming.
Comment 5 Mark Rowe (bdash) 2007-07-05 06:49:18 PDT
Landed in r24016.