RESOLVED FIXED 144445
[GTK] Web Inspector: Remove some unused Images 
https://bugs.webkit.org/show_bug.cgi?id=144445
Summary [GTK] Web Inspector: Remove some unused Images
Andres Gomez Garcia
Reported 2015-04-30 04:11:52 PDT
After bug 144412 was fixed, we have some unused images in the GTK port.
Attachments
Patch to remove unused images in the gtk port (33.20 KB, patch)
2015-04-30 04:17 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.56 KB, patch)
2015-04-30 06:08 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.20 KB, patch)
2015-04-30 06:14 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.21 KB, patch)
2015-04-30 09:32 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andres Gomez Garcia
Comment 1 2015-04-30 04:12:06 PDT
Taking ...
Radar WebKit Bug Importer
Comment 2 2015-04-30 04:12:17 PDT
<rdar://problem/20761473>
Andres Gomez Garcia
Comment 3 2015-04-30 04:17:21 PDT
Created attachment 252050 [details] Patch to remove unused images in the gtk port
Andres Gomez Garcia
Comment 4 2015-04-30 05:44:25 PDT
Comment on attachment 252050 [details] Patch to remove unused images in the gtk port gtk build is failing :(
Carlos Garcia Campos
Comment 5 2015-04-30 05:46:59 PDT
(In reply to comment #4) > Comment on attachment 252050 [details] > Patch to remove unused images in the gtk port > > gtk build is failing :( But has nothing to do with this patch, no?
Andres Gomez Garcia
Comment 6 2015-04-30 05:50:45 PDT
Comment on attachment 252050 [details] Patch to remove unused images in the gtk port I, actually, don't see anything wrong with this patch ...
Andres Gomez Garcia
Comment 7 2015-04-30 06:08:00 PDT
Created attachment 252055 [details] Patch for landing
Andres Gomez Garcia
Comment 8 2015-04-30 06:14:40 PDT
Created attachment 252056 [details] Patch for landing
WebKit Commit Bot
Comment 9 2015-04-30 06:16:27 PDT
Comment on attachment 252056 [details] Patch for landing Rejecting attachment 252056 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 252056, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6716258456174592
Andres Gomez Garcia
Comment 10 2015-04-30 09:32:35 PDT
Created attachment 252063 [details] Patch for landing
WebKit Commit Bot
Comment 11 2015-04-30 10:19:15 PDT
Comment on attachment 252063 [details] Patch for landing Clearing flags on attachment: 252063 Committed r183627: <http://trac.webkit.org/changeset/183627>
WebKit Commit Bot
Comment 12 2015-04-30 10:19:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.