Bug 144441 - [GTK] Web Inspector: Further optimize SVG images
Summary: [GTK] Web Inspector: Further optimize SVG images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gomez Garcia
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-30 03:24 PDT by Andres Gomez Garcia
Modified: 2015-05-05 14:32 PDT (History)
11 users (show)

See Also:


Attachments
Patch (629.87 KB, patch)
2015-05-05 11:26 PDT, Andres Gomez Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gomez Garcia 2015-04-30 03:24:31 PDT
As mentioned in bug 143476 comment 7, GTK SVG images can be further optimized.
Comment 1 Radar WebKit Bug Importer 2015-04-30 03:24:48 PDT
<rdar://problem/20761061>
Comment 2 Andres Gomez Garcia 2015-05-05 11:22:21 PDT
I've continued improving the customized script which now makes use of the scour tool (http://www.codedread.com/scour/) and also my personal forked copy of the svgo tool (https://github.com/tanty/svgo).

This customized script can be found at:
https://github.com/tanty/design-hodgepodge/blob/master/WebKit/WebInspector/sandbox/optimizing.sh

The original SVG files that I used to create material can be found at:
https://github.com/tanty/design-hodgepodge/tree/master/WebKit/WebInspector
Comment 3 Andres Gomez Garcia 2015-05-05 11:26:36 PDT
Created attachment 252391 [details]
Patch
Comment 4 Joseph Pecoraro 2015-05-05 11:45:18 PDT
Comment on attachment 252391 [details]
Patch

Nice! r=me
Comment 5 Andres Gomez Garcia 2015-05-05 13:45:34 PDT
(In reply to comment #4)
> Comment on attachment 252391 [details]
> Patch
> 
> Nice! r=me

Thanks for the review!
Comment 6 WebKit Commit Bot 2015-05-05 14:32:37 PDT
Comment on attachment 252391 [details]
Patch

Clearing flags on attachment: 252391

Committed r183830: <http://trac.webkit.org/changeset/183830>
Comment 7 WebKit Commit Bot 2015-05-05 14:32:41 PDT
All reviewed patches have been landed.  Closing bug.