Bug 144435 - [EFL] CMake should be failed if openwebrtc package does not exist but ENABLE_MEDIA_STREAM is ON
Summary: [EFL] CMake should be failed if openwebrtc package does not exist but ENABLE_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 21:57 PDT by Ryuan Choi
Modified: 2015-04-29 23:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2015-04-29 22:06 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2015-04-29 23:28 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-04-29 21:57:45 PDT 
ewebkit should include openwebrtc if ENABLE_MEDIA_STREAM is ON.
If not, linker will complain at the almost end of build.

In order to catch it earilier, we'd better to add REQUIRED field in find_package or raise FATAL_ERROR with some message like GTK port did.
Comment 1 Ryuan Choi 2015-04-29 22:06:45 PDT 
Created attachment 252039 [details]
Patch
Comment 2 Gyuyoung Kim 2015-04-29 22:58:16 PDT 
Comment on attachment 252039 [details]
Patch

Oh, right. When we failed to build openwebrtc via jhbuild, it was hard to find what is problem.
Comment 3 Ryuan Choi 2015-04-29 23:28:21 PDT 
Created attachment 252044 [details]
Patch
Comment 4 Ryuan Choi 2015-04-29 23:38:39 PDT 
Comment on attachment 252044 [details]
Patch

Clearing flags on attachment: 252044

Committed r183619: <http://trac.webkit.org/changeset/183619>
Comment 5 Ryuan Choi 2015-04-29 23:38:55 PDT 
All reviewed patches have been landed.  Closing bug.