WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144435
[EFL] CMake should be failed if openwebrtc package does not exist but ENABLE_MEDIA_STREAM is ON
https://bugs.webkit.org/show_bug.cgi?id=144435
Summary
[EFL] CMake should be failed if openwebrtc package does not exist but ENABLE_...
Ryuan Choi
Reported
2015-04-29 21:57:45 PDT
ewebkit should include openwebrtc if ENABLE_MEDIA_STREAM is ON. If not, linker will complain at the almost end of build. In order to catch it earilier, we'd better to add REQUIRED field in find_package or raise FATAL_ERROR with some message like GTK port did.
Attachments
Patch
(1.90 KB, patch)
2015-04-29 22:06 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
Patch
(1.90 KB, patch)
2015-04-29 23:28 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2015-04-29 22:06:45 PDT
Created
attachment 252039
[details]
Patch
Gyuyoung Kim
Comment 2
2015-04-29 22:58:16 PDT
Comment on
attachment 252039
[details]
Patch Oh, right. When we failed to build openwebrtc via jhbuild, it was hard to find what is problem.
Ryuan Choi
Comment 3
2015-04-29 23:28:21 PDT
Created
attachment 252044
[details]
Patch
Ryuan Choi
Comment 4
2015-04-29 23:38:39 PDT
Comment on
attachment 252044
[details]
Patch Clearing flags on attachment: 252044 Committed
r183619
: <
http://trac.webkit.org/changeset/183619
>
Ryuan Choi
Comment 5
2015-04-29 23:38:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug