Bug 144434 - Inefficient HashMap use in RTCStatsResponse.cpp
Summary: Inefficient HashMap use in RTCStatsResponse.cpp
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 20:41 PDT by Joseph Pecoraro
Modified: 2015-05-04 12:24 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.41 KB, patch)
2015-04-29 20:43 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-29 20:41:46 PDT 
* SUMMARY
Inefficient HashMap use in RTCStatsResponse.cpp.

We should never do a HashMap::find followed by a HashMap::get.

Searching JavaScriptCore & WebCore this was the only instance of that pattern!
Comment 1 Joseph Pecoraro 2015-04-29 20:43:38 PDT 
Created attachment 252034 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2015-05-02 07:28:39 PDT 
Comment on attachment 252034 [details]
[PATCH] Proposed Fix

Do you understand why the build failed on GTK and EFL?