Bug 144427 - Fix the EFL build after r183595
Summary: Fix the EFL build after r183595
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks: 143684
  Show dependency tree / graph
 
Reported: 2015-04-29 18:59 PDT by Hunseop Jeong
Modified: 2015-04-30 03:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2015-04-29 19:02 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (1.96 KB, patch)
2015-04-29 19:36 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-04-29 18:59:51 PDT 
../../Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:91:13: error: ‘void WebKit::updateWheelEventTestTriggersIfNeeded(uint64_t)’ defined but not used [-Werror=unused-function]
 static void updateWheelEventTestTriggersIfNeeded(uint64_t pageID)

https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21547/steps/compile-webkit/logs/stdio
Comment 1 Hunseop Jeong 2015-04-29 19:02:04 PDT 
Created attachment 252022 [details]
Patch
Comment 2 Gyuyoung Kim 2015-04-29 19:27:50 PDT 
Comment on attachment 252022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252022&action=review

> Source/WebKit2/ChangeLog:9
> +        (WebKit::updateWheelEventTestTriggersIfNeeded): Deleted.

Wrong description. updateWheelEventTestTriggersIfNeeded() is guarded by #if ENABLE(CSS_SCROLL_SNAP) || ENABLE(RUBBER_BANDING).
Comment 3 Hunseop Jeong 2015-04-29 19:36:51 PDT 
Created attachment 252028 [details]
Patch
Comment 4 Hunseop Jeong 2015-04-29 19:42:36 PDT 
(In reply to comment #2)
> Comment on attachment 252022 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252022&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        (WebKit::updateWheelEventTestTriggersIfNeeded): Deleted.
> 
> Wrong description. updateWheelEventTestTriggersIfNeeded() is guarded by #if
> ENABLE(CSS_SCROLL_SNAP) || ENABLE(RUBBER_BANDING).

Thanks for the review. I will try to practice the writing description.
Comment 5 Gyuyoung Kim 2015-04-29 19:45:38 PDT 
Comment on attachment 252028 [details]
Patch

Clearing flags on attachment: 252028

Committed r183605: <http://trac.webkit.org/changeset/183605>
Comment 6 Gyuyoung Kim 2015-04-29 19:45:44 PDT 
All reviewed patches have been landed.  Closing bug.