Bug 144426 - Crash at WebCore::Document::absoluteRegionForEventTargets
Summary: Crash at WebCore::Document::absoluteRegionForEventTargets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 144432
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-29 18:29 PDT by Simon Fraser (smfr)
Modified: 2015-04-29 21:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.82 KB, patch)
2015-04-29 18:32 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-04-29 18:29:26 PDT
Crash at WebCore::Document::absoluteRegionForEventTargets
Comment 1 Simon Fraser (smfr) 2015-04-29 18:32:23 PDT
Created attachment 252020 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-04-29 18:33:05 PDT
rdar://problem/20502166
Comment 3 Tim Horton 2015-04-29 18:35:27 PDT
Comment on attachment 252020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252020&action=review

> LayoutTests/fast/events/wheelevent-in-reattached-frame-expected.txt:6
> +PASS internals.wheelEventHandlerCount() is 0

Are there tests that test that this works at all?
Comment 4 Simon Fraser (smfr) 2015-04-29 18:36:07 PDT
(In reply to comment #3)
> Comment on attachment 252020 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252020&action=review
> 
> > LayoutTests/fast/events/wheelevent-in-reattached-frame-expected.txt:6
> > +PASS internals.wheelEventHandlerCount() is 0

Yes!
> Are there tests that test that this works at all?
Comment 5 Simon Fraser (smfr) 2015-04-29 18:40:06 PDT
https://trac.webkit.org/r183600
Comment 6 Alexey Proskuryakov 2015-04-29 19:15:54 PDT
This broke a bunch of tests: https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r183600%20(13679)/results.html

Simon, are you available to fix now?
Comment 8 WebKit Commit Bot 2015-04-29 19:58:47 PDT
Re-opened since this is blocked by bug 144432
Comment 9 Simon Fraser (smfr) 2015-04-29 20:57:00 PDT
I forgot to commit a required resource for the tests.
Comment 10 Simon Fraser (smfr) 2015-04-29 21:17:08 PDT
Re-landed with test fix: https://trac.webkit.org/r183614