Bug 144426 – Crash at WebCore::Document::absoluteRegionForEventTargets

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Crash at WebCore::Document::absoluteRegionForEventTargets

[Simon Fraser (smfr)]

Created attachment 252020 [details]
Patch

[Simon Fraser (smfr)]

rdar://problem/20502166

[Tim Horton]

Comment on attachment 252020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252020&action=review

> LayoutTests/fast/events/wheelevent-in-reattached-frame-expected.txt:6
> +PASS internals.wheelEventHandlerCount() is 0

Are there tests that test that this works at all?

[Simon Fraser (smfr)]

(In reply to comment #3)
> Comment on attachment 252020 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252020&action=review
> 
> > LayoutTests/fast/events/wheelevent-in-reattached-frame-expected.txt:6
> > +PASS internals.wheelEventHandlerCount() is 0

Yes!
> Are there tests that test that this works at all?

[Simon Fraser (smfr)]

https://trac.webkit.org/r183600

[Alexey Proskuryakov]

This broke a bunch of tests: https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r183600%20(13679)/results.html

Simon, are you available to fix now?

[Alexey Proskuryakov]

And by "a bunch", I mean the two new tests:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fwheelevent-in-frame.html

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fwheelevent-in-reattached-frame.html

Rolling out.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 144432

[Simon Fraser (smfr)]

I forgot to commit a required resource for the tests.

[Simon Fraser (smfr)]

Re-landed with test fix: https://trac.webkit.org/r183614