Bug 144421 - [iOS] tapping in the middle of a word in editable content should not select the word.
Summary: [iOS] tapping in the middle of a word in editable content should not select t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 17:26 PDT by Enrica Casucci
Modified: 2015-04-30 11:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2015-04-29 17:29 PDT, Enrica Casucci 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-04-29 17:26:13 PDT 
We want to revert it to the original behavior.

rdar://problem/20710948
Comment 1 Enrica Casucci 2015-04-29 17:29:10 PDT 
Created attachment 252013 [details]
Patch
Comment 2 Tim Horton 2015-04-29 17:33:23 PDT 
Comment on attachment 252013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252013&action=review

> Source/WebKit2/ChangeLog:9
> +        Reverting to the original behavior.

original before a specific revision?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:969
> +            result = wordRange->startPosition();

Can this range ever be null? I know Range likes to be null at inopportune times.
Comment 3 Enrica Casucci 2015-04-30 10:50:27 PDT 
(In reply to comment #2)
> Comment on attachment 252013 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252013&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Reverting to the original behavior.
> 
> original before a specific revision?
> 
> > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:969
> > +            result = wordRange->startPosition();
> 
> Can this range ever be null? I know Range likes to be null at inopportune
> times.

Yes. I'll add a check. Thanks!
Comment 4 Enrica Casucci 2015-04-30 11:22:31 PDT 
Committed revision 183635.