RESOLVED FIXED 144419
Run javascriptcore tests on Windows without cygwin
https://bugs.webkit.org/show_bug.cgi?id=144419
Summary Run javascriptcore tests on Windows without cygwin
Alex Christensen
Reported 2015-04-29 16:23:35 PDT
/usr/bin/env doesn't work well without cygwin. It probably isn't necessary, anyways.
Attachments
Patch (1.38 KB, patch)
2015-04-29 16:24 PDT, Alex Christensen
no flags
Patch (1.19 KB, patch)
2015-04-29 16:33 PDT, Alex Christensen
no flags
Patch (1.20 KB, patch)
2015-04-29 16:35 PDT, Alex Christensen
no flags
Alex Christensen
Comment 1 2015-04-29 16:24:13 PDT
Brent Fulgham
Comment 2 2015-04-29 16:26:19 PDT
Comment on attachment 252003 [details] Patch Will this break things for UNIX users? I think "/usr/bin/env" is the canonical way to get the path to an executable (which might be /usr/bin/ruby, /usr/local/bin/ruby, /opt/local/bin/ruby, etc.)
Alex Christensen
Comment 3 2015-04-29 16:33:17 PDT
Brent Fulgham
Comment 4 2015-04-29 16:34:12 PDT
Comment on attachment 252005 [details] Patch r=me.
Alex Christensen
Comment 5 2015-04-29 16:35:15 PDT
WebKit Commit Bot
Comment 6 2015-04-29 17:25:10 PDT
Comment on attachment 252006 [details] Patch Clearing flags on attachment: 252006 Committed r183593: <http://trac.webkit.org/changeset/183593>
WebKit Commit Bot
Comment 7 2015-04-29 17:25:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.