Bug 144419 - Run javascriptcore tests on Windows without cygwin
Summary: Run javascriptcore tests on Windows without cygwin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 16:23 PDT by Alex Christensen
Modified: 2015-04-29 17:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2015-04-29 16:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.19 KB, patch)
2015-04-29 16:33 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.20 KB, patch)
2015-04-29 16:35 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-04-29 16:23:35 PDT 
/usr/bin/env doesn't work well without cygwin.  It probably isn't necessary, anyways.
Comment 1 Alex Christensen 2015-04-29 16:24:13 PDT 
Created attachment 252003 [details]
Patch
Comment 2 Brent Fulgham 2015-04-29 16:26:19 PDT 
Comment on attachment 252003 [details]
Patch

Will this break things for UNIX users? I think "/usr/bin/env" is the canonical way to get the path to an executable (which might be /usr/bin/ruby, /usr/local/bin/ruby, /opt/local/bin/ruby, etc.)
Comment 3 Alex Christensen 2015-04-29 16:33:17 PDT 
Created attachment 252005 [details]
Patch
Comment 4 Brent Fulgham 2015-04-29 16:34:12 PDT 
Comment on attachment 252005 [details]
Patch

r=me.
Comment 5 Alex Christensen 2015-04-29 16:35:15 PDT 
Created attachment 252006 [details]
Patch
Comment 6 WebKit Commit Bot 2015-04-29 17:25:10 PDT 
Comment on attachment 252006 [details]
Patch

Clearing flags on attachment: 252006

Committed r183593: <http://trac.webkit.org/changeset/183593>
Comment 7 WebKit Commit Bot 2015-04-29 17:25:12 PDT 
All reviewed patches have been landed.  Closing bug.