Bug 144415 - Web Inspector: Remove FrameContentView.js
Summary: Web Inspector: Remove FrameContentView.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-04-29 15:40 PDT by Timothy Hatcher
Modified: 2015-05-01 07:25 PDT (History)
9 users (show)

See Also:

Attachments
Patch (15.51 KB, patch)
2015-04-29 15:42 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-29 15:40:49 PDT 
We don't use FrameContentView.js anymore.
Comment 1 Timothy Hatcher 2015-04-29 15:42:32 PDT 
Created attachment 251996 [details]
Patch
Comment 2 Andres Gomez Garcia 2015-04-30 04:27:06 PDT 
Comment on attachment 251996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251996&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        * UserInterface/Images/SourceCode.svg: Removed.

Could you also remove these SVG images in the gtk subdir?
Comment 3 Joseph Pecoraro 2015-04-30 12:09:50 PDT 
Comment on attachment 251996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251996&action=review

r=me, Might still be able to remove the GTK images.

> Source/WebInspectorUI/ChangeLog:19
> +        * UserInterface/Views/ResourceSidebarPanel.js:
> +        (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
> +        (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
> +        Simplify the code here. We don't need these checks now with tabs and the Storage tab.

Could be its own change.
Comment 4 Timothy Hatcher 2015-05-01 07:25:47 PDT 
Comment on attachment 251996 [details]
Patch

https://trac.webkit.org/r183671