Bug 144400 – [WTF] Remove Functional.h inclusions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

Remove Functional.h

[Zan Dobersek]

Created attachment 251973 [details]
Patch

[Zan Dobersek]

Comment on attachment 251973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251973&action=review

> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:-46
> -void callOnMainThread(const Function<void ()>& function)
> -{
> -    callOnMainThread(std::function<void ()>(function));
> -}

This might be the main blocker -- is Safari still invoking this function?

[Darin Adler]

Comment on attachment 251973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251973&action=review

Could you post a version of this patch that moves some of the contents of Functional.h into DeprecatedSymbolsUsedBySafari.mm? Then we can remove the DeprecatedSymbolsUsedBySafari.mm stuff when we verify it’s not needed for nightly builds.

Source/WTF/wtf/efl/DispatchQueueEfl.h:36:50: error: expected template-name before '<' token
 class DispatchQueue : public ThreadSafeRefCounted<DispatchQueue> {

Looks like we need to include ThreadSafeRefCounted.h in DispatchQueueEfl.h too.

>> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:-46
>> -}
> 
> This might be the main blocker -- is Safari still invoking this function?

Exactly right; I had a patch to remove Functional.h and I found this was the sticking point. We have to find out whether anyone is depending on using WebKit builds with older Safari. Apple engineering doesn’t depend on it, but some people outside Apple might be using the newer WebKit with the older Safari as part of nightly builds.

[Zan Dobersek]

Created attachment 252234 [details]
Patch

[Darin Adler]

Comment on attachment 252234 [details]
Patch

../../Source/WTF/wtf/efl/DispatchQueueEfl.h:64:5: error: 'Mutex' does not name a type

Looks like we need to add an include to DispatchQueueEfl.h -- please fix that before landing

[Zan Dobersek]

Created attachment 252299 [details]
Patch for landing

[Zan Dobersek]

Committed r183746: <http://trac.webkit.org/changeset/183746>