Bug 144400 - [WTF] Remove Functional.h inclusions
Summary: [WTF] Remove Functional.h inclusions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 11:17 PDT by Zan Dobersek
Modified: 2015-05-04 08:36 PDT (History)
0 users

See Also:

Attachments
Patch (57.15 KB, patch)
2015-04-29 12:02 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (13.65 KB, patch)
2015-05-02 09:59 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (13.62 KB, patch)
2015-05-04 00:23 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2015-04-29 11:17:31 PDT 
Remove Functional.h
Comment 1 Zan Dobersek 2015-04-29 12:02:19 PDT 
Created attachment 251973 [details]
Patch
Comment 2 Zan Dobersek 2015-04-29 12:06:20 PDT 
Comment on attachment 251973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251973&action=review

> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:-46
> -void callOnMainThread(const Function<void ()>& function)
> -{
> -    callOnMainThread(std::function<void ()>(function));
> -}

This might be the main blocker -- is Safari still invoking this function?
Comment 3 Darin Adler 2015-04-29 19:18:14 PDT 
Comment on attachment 251973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251973&action=review

Could you post a version of this patch that moves some of the contents of Functional.h into DeprecatedSymbolsUsedBySafari.mm? Then we can remove the DeprecatedSymbolsUsedBySafari.mm stuff when we verify it’s not needed for nightly builds.

Source/WTF/wtf/efl/DispatchQueueEfl.h:36:50: error: expected template-name before '<' token
 class DispatchQueue : public ThreadSafeRefCounted<DispatchQueue> {

Looks like we need to include ThreadSafeRefCounted.h in DispatchQueueEfl.h too.

>> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:-46
>> -}
> 
> This might be the main blocker -- is Safari still invoking this function?

Exactly right; I had a patch to remove Functional.h and I found this was the sticking point. We have to find out whether anyone is depending on using WebKit builds with older Safari. Apple engineering doesn’t depend on it, but some people outside Apple might be using the newer WebKit with the older Safari as part of nightly builds.
Comment 4 Zan Dobersek 2015-05-02 09:59:27 PDT 
Created attachment 252234 [details]
Patch
Comment 5 Darin Adler 2015-05-02 11:48:26 PDT 
Comment on attachment 252234 [details]
Patch

../../Source/WTF/wtf/efl/DispatchQueueEfl.h:64:5: error: 'Mutex' does not name a type

Looks like we need to add an include to DispatchQueueEfl.h -- please fix that before landing
Comment 6 Zan Dobersek 2015-05-04 00:23:22 PDT 
Created attachment 252299 [details]
Patch for landing
Comment 7 Zan Dobersek 2015-05-04 08:36:49 PDT 
Committed r183746: <http://trac.webkit.org/changeset/183746>