RESOLVED FIXED 144400
[WTF] Remove Functional.h inclusions
https://bugs.webkit.org/show_bug.cgi?id=144400
Summary [WTF] Remove Functional.h inclusions
Zan Dobersek
Reported 2015-04-29 11:17:31 PDT
Remove Functional.h
Attachments
Patch (57.15 KB, patch)
2015-04-29 12:02 PDT, Zan Dobersek
no flags
Patch (13.65 KB, patch)
2015-05-02 09:59 PDT, Zan Dobersek
no flags
Patch for landing (13.62 KB, patch)
2015-05-04 00:23 PDT, Zan Dobersek
no flags
Zan Dobersek
Comment 1 2015-04-29 12:02:19 PDT
Zan Dobersek
Comment 2 2015-04-29 12:06:20 PDT
Comment on attachment 251973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251973&action=review > Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:-46 > -void callOnMainThread(const Function<void ()>& function) > -{ > - callOnMainThread(std::function<void ()>(function)); > -} This might be the main blocker -- is Safari still invoking this function?
Darin Adler
Comment 3 2015-04-29 19:18:14 PDT
Comment on attachment 251973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251973&action=review Could you post a version of this patch that moves some of the contents of Functional.h into DeprecatedSymbolsUsedBySafari.mm? Then we can remove the DeprecatedSymbolsUsedBySafari.mm stuff when we verify it’s not needed for nightly builds. Source/WTF/wtf/efl/DispatchQueueEfl.h:36:50: error: expected template-name before '<' token class DispatchQueue : public ThreadSafeRefCounted<DispatchQueue> { Looks like we need to include ThreadSafeRefCounted.h in DispatchQueueEfl.h too. >> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:-46 >> -} > > This might be the main blocker -- is Safari still invoking this function? Exactly right; I had a patch to remove Functional.h and I found this was the sticking point. We have to find out whether anyone is depending on using WebKit builds with older Safari. Apple engineering doesn’t depend on it, but some people outside Apple might be using the newer WebKit with the older Safari as part of nightly builds.
Zan Dobersek
Comment 4 2015-05-02 09:59:27 PDT
Darin Adler
Comment 5 2015-05-02 11:48:26 PDT
Comment on attachment 252234 [details] Patch ../../Source/WTF/wtf/efl/DispatchQueueEfl.h:64:5: error: 'Mutex' does not name a type Looks like we need to add an include to DispatchQueueEfl.h -- please fix that before landing
Zan Dobersek
Comment 6 2015-05-04 00:23:22 PDT
Created attachment 252299 [details] Patch for landing
Zan Dobersek
Comment 7 2015-05-04 08:36:49 PDT
Note You need to log in before you can comment on or make changes to this bug.