RESOLVED FIXED144395
check-webkit-style: Don't complain about returning value from Objective-C method call in header 
https://bugs.webkit.org/show_bug.cgi?id=144395
Summary check-webkit-style: Don't complain about returning value from Objective-C met...
David Kilzer (:ddkilzer)
Reported 2015-04-29 10:07:27 PDT
In Bug 144362, an inline method was added to SoftLinking.h that returned the value from an Objective-C method call: + inline className *alloc##className##Instance() \ + { \ + return [get_##framework##_##className##Class() alloc]; \ + } \ However, check-webkit-style incorrectly flagged this as a style issue (see Bug 144362, Comment #24): ERROR: Source/WebCore/platform/mac/SoftLinking.h:327: Extra space before [ [whitespace/braces] [5] Additional issues noted while investigating this: - The category should be "whitespace/brackets", not "whitespace/braces". - There is no test coverage for the code that checks for "whitespace/brackets".
Attachments
Patch v1 (4.75 KB, patch)
2015-04-29 10:19 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2015-04-29 10:19:15 PDT
Created attachment 251962 [details] Patch v1
WebKit Commit Bot
Comment 2 2015-04-29 12:34:10 PDT
Comment on attachment 251962 [details] Patch v1 Clearing flags on attachment: 251962 Committed r183567: <http://trac.webkit.org/changeset/183567>
WebKit Commit Bot
Comment 3 2015-04-29 12:34:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.