Use the new API.
<rdar://problem/20718389>
Created attachment 251967 [details] Proposed patch.
Attachment 251967 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:53: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 251967 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=251967&action=review r=me, with nits > Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.h:53 > - virtual void showPlaybackTargetPicker(const FloatRect&, bool); > + virtual void showPlaybackTargetPicker(const FloatRect&, bool /*checkActiveRoute*/); nit: We should either not add a comment, or add the parameter name without a comment. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:47 > - virtual void showPlaybackTargetPicker(const FloatRect&, bool) override; > + virtual void showPlaybackTargetPicker(const FloatRect&, bool /*checkActiveRoute*/) override; Ditto. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:60 > + OutputeDeviceAvailabilityChanged = 1 << 0, Nit: Outpute > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:150 > + m_pendingActionTimer.stop(); > + m_pendingActionTimer.startOneShot(0); The .stop() isn't necessary. startOneShot() will stop the timer before re-targetting.
Comment on attachment 251967 [details] Proposed patch. Committed r183560: https://trac.webkit.org/r183560