Bug 144390 - Web Inspector: Remove Legacy images and styles
Summary: Web Inspector: Remove Legacy images and styles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-04-29 08:48 PDT by Timothy Hatcher
Modified: 2015-04-29 15:02 PDT (History)
9 users (show)

See Also:

Attachments
Patch (204.97 KB, patch)
2015-04-29 08:53 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-29 08:48:44 PDT 
The Legacy path is poor shape and hard to maintain and test.
Comment 1 Timothy Hatcher 2015-04-29 08:53:58 PDT 
Created attachment 251954 [details]
Patch
Comment 2 Joseph Pecoraro 2015-04-29 11:59:10 PDT 
Comment on attachment 251954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251954&action=review

Awesome! r=me, with 1 nit

> Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js:531
> +        generateModernImage();

The contents of this function are now just function foo() {}; foo();. You can drop the "inner function" and just inline it.
Comment 3 Timothy Hatcher 2015-04-29 15:02:48 PDT 
Comment on attachment 251954 [details]
Patch

https://trac.webkit.org/r183579