Bug 144388 - REGRESSION(r182573): [GTK] The default context menu contains an empty item since r182573
Summary: REGRESSION(r182573): [GTK] The default context menu contains an empty item si...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2015-04-29 06:39 PDT by Carlos Garcia Campos
Modified: 2015-04-29 08:51 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.39 KB, patch)
2015-04-29 06:41 PDT, Carlos Garcia Campos 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-04-29 06:39:21 PDT 
There used to be a method in ContextMenuItem to check if share menu item was supported or not, but since r182573, there's a method to get the share menu item. If the returned menu item is null, it's not added to the menu, but we are not returning a null ContextMenu item even though we don't support share menu item.
Comment 1 Carlos Garcia Campos 2015-04-29 06:41:50 PDT 
Created attachment 251948 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-04-29 08:51:04 PDT 
Committed r183547: <http://trac.webkit.org/changeset/183547>