Bug 144385 - Web Inspector: Navigation bar often looses last button when full
Summary: Web Inspector: Navigation bar often looses last button when full
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-29 04:53 PDT by Timothy Hatcher
Modified: 2015-04-29 12:20 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.15 KB, patch)
2015-04-29 04:57 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-29 04:53:26 PDT 
The layout of the navigation bar can often cause the last button to overflow. This is due to offsetWidth returning a rounded up value in with subpixel layout. We need to use getBoundingClientRect() so we don't accumulate the rounding as we add widths together during our layout functions.
Comment 1 Radar WebKit Bug Importer 2015-04-29 04:53:45 PDT 
<rdar://problem/20743712>
Comment 2 Timothy Hatcher 2015-04-29 04:57:09 PDT 
Created attachment 251947 [details]
Patch
Comment 3 Joseph Pecoraro 2015-04-29 11:32:13 PDT 
Comment on attachment 251947 [details]
Patch

r=me

There might be better / more descriptive names. Maybe subpixelOffsetWidth, preciseOffsetWidth?
Comment 4 WebKit Commit Bot 2015-04-29 12:20:42 PDT 
Comment on attachment 251947 [details]
Patch

Clearing flags on attachment: 251947

Committed r183565: <http://trac.webkit.org/changeset/183565>
Comment 5 WebKit Commit Bot 2015-04-29 12:20:46 PDT 
All reviewed patches have been landed.  Closing bug.