RESOLVED FIXED 144385
Web Inspector: Navigation bar often looses last button when full 
https://bugs.webkit.org/show_bug.cgi?id=144385
Summary Web Inspector: Navigation bar often looses last button when full
Timothy Hatcher
Reported 2015-04-29 04:53:26 PDT
The layout of the navigation bar can often cause the last button to overflow. This is due to offsetWidth returning a rounded up value in with subpixel layout. We need to use getBoundingClientRect() so we don't accumulate the rounding as we add widths together during our layout functions.
Attachments
Patch (8.15 KB, patch)
2015-04-29 04:57 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-04-29 04:53:45 PDT
<rdar://problem/20743712>
Timothy Hatcher
Comment 2 2015-04-29 04:57:09 PDT
Created attachment 251947 [details] Patch
Joseph Pecoraro
Comment 3 2015-04-29 11:32:13 PDT
Comment on attachment 251947 [details] Patch r=me There might be better / more descriptive names. Maybe subpixelOffsetWidth, preciseOffsetWidth?
WebKit Commit Bot
Comment 4 2015-04-29 12:20:42 PDT
Comment on attachment 251947 [details] Patch Clearing flags on attachment: 251947 Committed r183565: <http://trac.webkit.org/changeset/183565>
WebKit Commit Bot
Comment 5 2015-04-29 12:20:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.