The new CSS Box Alignment specification introduces more complex values and syntax for defining alignment properties. Most of the alignment values were just keyword identifiers, but the new syntax allows different combinations of identifiers to determine the alignment behavior (eg. overflow-alignment keyword). This bug describes the need of a refactoring of current alignment logic to define one or more classes to store all the alignment fields. This class will replace the unsigned fields in the StyleRareNonInherited class, hence it will increase it sized considerably. We should take that into account when submitting and reviewing patches.
Created attachment 251946 [details] Patch
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/StyleRareNonInheritedData.h:37:10: fatal error: 'StyleSelfAlignmentData.h' file not found I suspect this is adding a new header file to the Xcode project but not marking it “Private”, which is needed if it’s used outside WebCore.
Created attachment 251982 [details] Patch
Comment on attachment 251982 [details] Patch r=me
Comment on attachment 251982 [details] Patch Clearing flags on attachment: 251982 Committed r183591: <http://trac.webkit.org/changeset/183591>
All reviewed patches have been landed. Closing bug.