Bug 144379 – [GTK] Add libnotify in gtk install-dependencies

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joonghun Park]

Add libnotify-dev in install-dependencies of Gtk port. Without this dependency package, Gtk port build is impossible currently.

[Joonghun Park]

Created attachment 251929 [details]
Patch

[Zan Dobersek]

Comment on attachment 251929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251929&action=review

> Tools/gtk/install-dependencies:81
> +		libnotify-dev \

This should use spaces instead of tabs. Please fix before committing.

[Joonghun Park]

(In reply to comment #2)
> Comment on attachment 251929 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251929&action=review
> 
> > Tools/gtk/install-dependencies:81
> > +		libnotify-dev \
> 
> This should use spaces instead of tabs. Please fix before committing.

Ok, I will revise it :)

[Joonghun Park]

Created attachment 251933 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 251933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251933&action=review

> Tools/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Missing reviewer name here, because Zan set r+ed.

[Joonghun Park]

(In reply to comment #5)
> Comment on attachment 251933 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251933&action=review
> 
> > Tools/ChangeLog:6
> > +        Reviewed by NOBODY (OOPS!).
> 
> Missing reviewer name here, because Zan set r+ed.

Ah, I had to write it into ChangeLog, but I missed it. Thank you, I will re-upload this one.

[Joonghun Park]

Created attachment 251934 [details]
Patch

[Joonghun Park]

Created attachment 251935 [details]
Patch

[Joonghun Park]

Created attachment 251936 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 251936 [details]
Patch

Clearing flags on attachment: 251936

Committed r183539: <http://trac.webkit.org/changeset/183539>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

Reopening: please make sure to fix all three supported distros (Arch, Debian, Fedora) when modifying this file. The Arch package is simply libnotify and the Fedora package is libnotify-devel.

[Gyuyoung Kim]

(In reply to comment #12)
> Reopening: please make sure to fix all three supported distros (Arch,
> Debian, Fedora) when modifying this file. The Arch package is simply
> libnotify and the Fedora package is libnotify-devel.

Has GTK port's install-dependency script supported Fedora, Arch as well ?

[Michael Catanzaro]

(In reply to comment #13)
> Has GTK port's install-dependency script supported Fedora, Arch as well ?

Yup. (More distros welcome.)

[Joonghun Park]

(In reply to comment #12)
> Reopening: please make sure to fix all three supported distros (Arch,
> Debian, Fedora) when modifying this file. The Arch package is simply
> libnotify and the Fedora package is libnotify-devel.

I didn't know which distros GTK port supports currently.
Thank you for your teaching :) 
For now, I will add what you commented here for Fedora and Arch.

[Joonghun Park]

Created attachment 252143 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 252143 [details]
Patch

LGTM

[WebKit Commit Bot]

Comment on attachment 252143 [details]
Patch

Clearing flags on attachment: 252143

Committed r183743: <http://trac.webkit.org/changeset/183743>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.