Bug 144373 – REGRESSION(181868): Windows Live SkyDrive cannot open an excel file

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

* SUMMARY
REGRESSION(181868): Windows Live SkyDrive cannot open an excel file.

* STEPS TO REPRODUCE
1. Open <https://skydrive.live.com>
2. Sign In
3. Open/Create an Excel document
  => never loads, infinitely stays on loading page

* NOTES
The page does stuff like:

(Ewa.js)
---------------------
    var w = window, wHTMLElementPrototype = w.HTMLElement.prototype;
    wHTMLElementPrototype.__defineGetter__("innerText", function() {
        try {
            return this.textContent
        } catch (d) {
            for (var b = "", a = 0, c = this.childNodes.length; a < c; a++)
                if (this.childNodes[a].nodeType == 3) b += this.childNodes[a].textContent;
            return b
        }
    });
    wHTMLElementPrototype.__defineSetter__("innerText", function(b) {
        var a = document.createTextNode(b);
        this.innerHTML = "";
        this.appendChild(a)
    });
---------------------

• Firefox: the properties don’t exist on HTMLElement.prototype, so they are created
• Chrome: the properties do exist and are configurable, so they are updated
• WebKit: the properties do exist and are NOT configurable
  - before r181868 we failed silently
  - after r181868 we throw an exception

[Joseph Pecoraro]

Hmm, it seems Web IDL prefers that interface attributes be configurable by default:
http://www.w3.org/TR/WebIDL/#es-attributes

> The property has attributes
> { [[Get]]: G, [[Set]]: S, [[Enumerable]]: true, [[Configurable]]: configurable },
> where: configurable is false if the attribute was declared with the
> [Unforgeable] extended attribute and true otherwise;

Seems like the ultimate best path forward would be to:

  (1) Make IDL attributes configurable
  (2) Keep this exception when trying to reconfigure a non-configurable property.

But for now, lets just go back to failing silently.

[Joseph Pecoraro]

<rdar://problem/20642043>

[Joseph Pecoraro]

Created attachment 251920 [details]
[PATCH] Proposed Fix

=(. This will Reopen 142934 and in there I have a plan for hopefully re-enabling this warning.

[WebKit Commit Bot]

Comment on attachment 251920 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 251920

Committed r183535: <http://trac.webkit.org/changeset/183535>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Geoffrey Garen]

> • Firefox: the properties don’t exist on HTMLElement.prototype, so they are
> created

O'rly? Most DOM properties in Firefox are getters and setters in the prototype chain. Out of curiosity, where *does* Firefox define innerText?

[Joseph Pecoraro]

(In reply to comment #6)
> > • Firefox: the properties don’t exist on HTMLElement.prototype, so they are
> > created
> 
> O'rly? Most DOM properties in Firefox are getters and setters in the
> prototype chain. Out of curiosity, where *does* Firefox define innerText?

Firefox doesn't appear to support "innerText" at all.