Bug 144364 - [CMake] [GTK] Organize and clean up unused CMake variables
Summary: [CMake] [GTK] Organize and clean up unused CMake variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 16:45 PDT by Martin Robinson
Modified: 2015-04-29 09:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.58 KB, patch)
2015-04-28 16:49 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2015-04-28 16:45:14 PDT
We can lighten up OptionsGTK.cmake a bit by removing unused variables and moving some to more appropriate locations.
Comment 1 Martin Robinson 2015-04-28 16:49:21 PDT
Created attachment 251897 [details]
Patch
Comment 2 Michael Catanzaro 2015-04-28 17:32:54 PDT
Looks good to me.
Comment 3 Gyuyoung Kim 2015-04-28 18:01:15 PDT
Comment on attachment 251897 [details]
Patch

Looks fine.
Comment 4 Martin Robinson 2015-04-29 09:21:47 PDT
Comment on attachment 251897 [details]
Patch

Clearing flags on attachment: 251897

Committed r183550: <http://trac.webkit.org/changeset/183550>
Comment 5 Martin Robinson 2015-04-29 09:21:54 PDT
All reviewed patches have been landed.  Closing bug.