Bug 144361 - Increase stablility of run-benchmark script
Summary: Increase stablility of run-benchmark script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 16:30 PDT by dewei_zhu
Modified: 2015-04-28 17:52 PDT (History)
4 users (show)

See Also:


Attachments
Patch (21.98 KB, patch)
2015-04-28 16:39 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2015-04-28 16:30:04 PDT
Increase stablility of run-benchmark script
Comment 1 dewei_zhu 2015-04-28 16:39:41 PDT
Created attachment 251895 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-28 16:42:11 PDT
Attachment 251895 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:83:  [SimpleHTTPServerDriver.killServer] Instance of 'Popen' has no 'terminate' member  [pylint/E1101] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2015-04-28 16:53:09 PDT
Comment on attachment 251895 [details]
Patch

Rejecting attachment 251895 [details] from commit-queue.

dewei_zhu@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Commit Bot 2015-04-28 17:52:50 PDT
Comment on attachment 251895 [details]
Patch

Clearing flags on attachment: 251895

Committed r183520: <http://trac.webkit.org/changeset/183520>
Comment 5 WebKit Commit Bot 2015-04-28 17:52:54 PDT
All reviewed patches have been landed.  Closing bug.