Bug 144358 - [TextIndicator] Yellow highlight takes too long to fade out on scroll
Summary: [TextIndicator] Yellow highlight takes too long to fade out on scroll
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 15:30 PDT by Tim Horton
Modified: 2015-04-28 16:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (48.89 KB, patch)
2015-04-28 15:30 PDT, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-04-28 15:30:14 PDT 
[TextIndicator] Yellow highlight takes too long to fade out on scroll
Comment 1 Tim Horton 2015-04-28 15:30:35 PDT 
Created attachment 251890 [details]
Patch
Comment 2 Tim Horton 2015-04-28 15:31:13 PDT 
<rdar://problem/19451011>
Comment 3 Brent Fulgham 2015-04-28 16:15:16 PDT 
This creates an EFL build failure:

../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h:184:18: error: 'virtual void WebKit::WebView::setTextIndicator(WTF::PassRefPtr<WebCore::TextIndicator>, bool)' marked override, but does not override
     virtual void setTextIndicator(PassRefPtr<WebCore::TextIndicator>, bool) override;
Comment 4 Tim Horton 2015-04-28 16:18:14 PDT 
(In reply to comment #3)
> This creates an EFL build failure:
> 
> ../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h:184:18: error:
> 'virtual void
> WebKit::WebView::setTextIndicator(WTF::PassRefPtr<WebCore::TextIndicator>,
> bool)' marked override, but does not override
>      virtual void setTextIndicator(PassRefPtr<WebCore::TextIndicator>, bool)
> override;

Yep. In WebKit2. I haven't landed it yet because I'm going to make a minor-but-untested effort to fix EFL and GTK before landing.
Comment 5 Tim Horton 2015-04-28 16:29:23 PDT 
http://trac.webkit.org/changeset/183517