RESOLVED FIXED 144358
[TextIndicator] Yellow highlight takes too long to fade out on scroll 
https://bugs.webkit.org/show_bug.cgi?id=144358
Summary [TextIndicator] Yellow highlight takes too long to fade out on scroll
Tim Horton
Reported 2015-04-28 15:30:14 PDT
[TextIndicator] Yellow highlight takes too long to fade out on scroll
Attachments
Patch (48.89 KB, patch)
2015-04-28 15:30 PDT, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-04-28 15:30:35 PDT
Created attachment 251890 [details] Patch
Tim Horton
Comment 2 2015-04-28 15:31:13 PDT
<rdar://problem/19451011>
Brent Fulgham
Comment 3 2015-04-28 16:15:16 PDT
This creates an EFL build failure: ../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h:184:18: error: 'virtual void WebKit::WebView::setTextIndicator(WTF::PassRefPtr<WebCore::TextIndicator>, bool)' marked override, but does not override virtual void setTextIndicator(PassRefPtr<WebCore::TextIndicator>, bool) override;
Tim Horton
Comment 4 2015-04-28 16:18:14 PDT
(In reply to comment #3) > This creates an EFL build failure: > > ../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h:184:18: error: > 'virtual void > WebKit::WebView::setTextIndicator(WTF::PassRefPtr<WebCore::TextIndicator>, > bool)' marked override, but does not override > virtual void setTextIndicator(PassRefPtr<WebCore::TextIndicator>, bool) > override; Yep. In WebKit2. I haven't landed it yet because I'm going to make a minor-but-untested effort to fix EFL and GTK before landing.
Tim Horton
Comment 5 2015-04-28 16:29:23 PDT
http://trac.webkit.org/changeset/183517
Note You need to log in before you can comment on or make changes to this bug.