Bug 144356 - Failure when building WebKit for appletvsimulator
Summary: Failure when building WebKit for appletvsimulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jake Nielsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 14:09 PDT by Jake Nielsen
Modified: 2015-04-30 05:23 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.81 KB, patch)
2015-04-28 14:18 PDT, Jake Nielsen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Nielsen 2015-04-28 14:09:17 PDT
See rdar://problem/20641901 for details
Comment 1 Jake Nielsen 2015-04-28 14:18:09 PDT
Created attachment 251886 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-29 15:42:35 PDT
Comment on attachment 251886 [details]
Patch

Clearing flags on attachment: 251886

Committed r183583: <http://trac.webkit.org/changeset/183583>
Comment 3 WebKit Commit Bot 2015-04-29 15:42:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Joseph Pecoraro 2015-04-29 17:42:36 PDT
Comment on attachment 251886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review

> Tools/WebKitTestRunner/Makefile:11
> -ifneq (,$(findstring iphone,$(SDKROOT)))
> +ifeq (,$(findstring macosx,$(SDKROOT)))
>  	ifeq (,$(findstring clean,$(MAKECMDGOALS)))
>  		OTHER_OPTIONS += -target WebKitTestRunnerApp
>  	endif

This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs.
Comment 5 Joseph Pecoraro 2015-04-29 17:43:18 PDT
Comment on attachment 251886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review

>> Tools/WebKitTestRunner/Makefile:11
>>  	endif
> 
> This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs.

To test, on a Mac:

  shell> cd Tools/WebKitTestRunner; make
    => errors building WebKitTestRunnerApp
Comment 6 Joseph Pecoraro 2015-04-29 17:48:42 PDT
Ahh, interesting. This tends to be the case when SDKROOT is not set.

  shell> make SDKROOT=macosx release
    => all is fine

  shell> make release
    => failures trying to build WebKitTestRunnerApp

We probably should treat an empty SDKROOT as macosx.
Comment 7 Jake Nielsen 2015-04-29 17:50:12 PDT
:(