Bug 144353 - Replace HTMLMediaElement's seek timer with a task queue.
Summary: Replace HTMLMediaElement's seek timer with a task queue.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 13:41 PDT by Jer Noble
Modified: 2015-04-29 09:51 PDT (History)
1 user (show)

See Also:

Attachments
Patch (14.09 KB, patch)
2015-04-28 13:48 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (16.97 KB, patch)
2015-04-29 09:08 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-04-28 13:41:53 PDT 
Replace HTMLMediaElement's seek timer with a task queue.
Comment 1 Jer Noble 2015-04-28 13:48:18 PDT 
Created attachment 251885 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-28 13:50:17 PDT 
Attachment 251885 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElement.cpp:2366:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2015-04-28 13:56:21 PDT 
Comment on attachment 251885 [details]
Patch

Don't you need to add GenericTaskQueue.* to the other build system?
Comment 4 Jer Noble 2015-04-28 13:59:12 PDT 
(In reply to comment #3)
> Comment on attachment 251885 [details]
> Patch
> 
> Don't you need to add GenericTaskQueue.* to the other build system?

Oh, good point.
Comment 5 Jer Noble 2015-04-29 09:08:42 PDT 
Created attachment 251956 [details]
Patch for landing
Comment 6 Jer Noble 2015-04-29 09:51:26 PDT 
Committed r183554: <http://trac.webkit.org/changeset/183554>