Bug 144352 – Web Inspector: Scope Chain sidebar should be selected immediately when paused

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Scope Chain sidebar should be selected immediately when paused.

I think this might be a regression in the new Tab UI. I'm pretty sure we were forcing it selected when we paused before. If you were showing the sidebar, and you had Resources selected, when the Scope Chain sidebar appears, it isn't selected. This leads to a poorer debugging experience because developers don't know that the scope chain sidebar is available.

Also, maybe the Resources sidebar is not very useful in the Debugger sidebar. Perhaps we should drop it here.

[Radar WebKit Bug Importer]

<rdar://problem/20733530>

[Timothy Hatcher]

Yes, this is a regression. Should be a simple fix.

[Timothy Hatcher]

Created attachment 252057 [details]
Patch

[Timothy Hatcher]

Comment on attachment 252057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252057&action=review

> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:-131
> -        this._contentBrowserRepresentedObjectsDidChange();

Silly git. I moved the body of the _contentBrowserRepresentedObjectsDidChange function into here. So the diff things I moved the other functions instead.

[Joseph Pecoraro]

Comment on attachment 252057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252057&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:71
> +    showScopeChainDetailsSidebarPanel: function()

I wonder if "activate" or "select" might be better naming. For a while I was confused about this showing up at all, instead of it being selected or not.

Either way, r=me.

[WebKit Commit Bot]

Comment on attachment 252057 [details]
Patch

Clearing flags on attachment: 252057

Committed r183642: <http://trac.webkit.org/changeset/183642>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.