Bug 144352 - Web Inspector: Scope Chain sidebar should be selected immediately when paused
Summary: Web Inspector: Scope Chain sidebar should be selected immediately when paused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-28 13:38 PDT by Joseph Pecoraro
Modified: 2015-04-30 13:05 PDT (History)
9 users (show)

See Also:


Attachments
Patch (9.45 KB, patch)
2015-04-30 07:32 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-28 13:38:14 PDT
* SUMMARY
Scope Chain sidebar should be selected immediately when paused.

I think this might be a regression in the new Tab UI. I'm pretty sure we were forcing it selected when we paused before. If you were showing the sidebar, and you had Resources selected, when the Scope Chain sidebar appears, it isn't selected. This leads to a poorer debugging experience because developers don't know that the scope chain sidebar is available.

Also, maybe the Resources sidebar is not very useful in the Debugger sidebar. Perhaps we should drop it here.
Comment 1 Radar WebKit Bug Importer 2015-04-28 13:39:02 PDT
<rdar://problem/20733530>
Comment 2 Timothy Hatcher 2015-04-28 14:50:37 PDT
Yes, this is a regression. Should be a simple fix.
Comment 3 Timothy Hatcher 2015-04-30 07:32:43 PDT
Created attachment 252057 [details]
Patch
Comment 4 Timothy Hatcher 2015-04-30 07:37:25 PDT
Comment on attachment 252057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252057&action=review

> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:-131
> -        this._contentBrowserRepresentedObjectsDidChange();

Silly git. I moved the body of the _contentBrowserRepresentedObjectsDidChange function into here. So the diff things I moved the other functions instead.
Comment 5 Joseph Pecoraro 2015-04-30 12:16:06 PDT
Comment on attachment 252057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252057&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:71
> +    showScopeChainDetailsSidebarPanel: function()

I wonder if "activate" or "select" might be better naming. For a while I was confused about this showing up at all, instead of it being selected or not.

Either way, r=me.
Comment 6 WebKit Commit Bot 2015-04-30 13:05:13 PDT
Comment on attachment 252057 [details]
Patch

Clearing flags on attachment: 252057

Committed r183642: <http://trac.webkit.org/changeset/183642>
Comment 7 WebKit Commit Bot 2015-04-30 13:05:17 PDT
All reviewed patches have been landed.  Closing bug.