Bug 144319 - [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
Summary: [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 01:49 PDT by Gyuyoung Kim
Modified: 2015-04-28 15:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2015-04-28 05:52 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (2.32 KB, patch)
2015-04-28 06:43 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-04-28 01:49:14 PDT 
Clean up unused include patch in TestWebKitAPI cmake files.
Comment 1 Gyuyoung Kim 2015-04-28 05:52:57 PDT 
Created attachment 251840 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-04-28 06:17:44 PDT 
Comment on attachment 251840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251840&action=review

rs=me if it builds on GTK and EFL too.

> Tools/ChangeLog:3
> +        [CMake] Remove unnecessary include patch in TestWebKitAPI cmake files

typo: patch -> paths

> Tools/ChangeLog:8
> +        Clean up unused include patch in these cmake files.

this line is unnecessary
Comment 3 Gyuyoung Kim 2015-04-28 06:43:56 PDT 
Created attachment 251846 [details]
Patch for landing
Comment 4 Gyuyoung Kim 2015-04-28 15:24:43 PDT 
I hope to land this patch after passing gtk ews though, now it seems to be broken. So I land this patch.
Comment 5 WebKit Commit Bot 2015-04-28 15:37:02 PDT 
Comment on attachment 251846 [details]
Patch for landing

Clearing flags on attachment: 251846

Committed r183512: <http://trac.webkit.org/changeset/183512>
Comment 6 WebKit Commit Bot 2015-04-28 15:37:05 PDT 
All reviewed patches have been landed.  Closing bug.