Bug 144308 - Disable App Nap in WebKitTestRunner UI process
Summary: Disable App Nap in WebKitTestRunner UI process
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2015-04-27 19:46 PDT by Alexey Proskuryakov
Modified: 2015-04-28 10:46 PDT (History)
5 users (show)

See Also:

proposed patch (1.78 KB, patch)
2015-04-27 19:52 PDT, Alexey Proskuryakov
dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-27 19:46:18 PDT
DumpRenderTree disables App Nap since bug 108400, and I just made WebKit2 secondary processes not app nap in bug 144155. But WebKitTestRunner itself can still be suppressed, as far as I can tell.
Comment 1 Alexey Proskuryakov 2015-04-27 19:52:03 PDT
Created attachment 251808 [details]
proposed patch

This changes process role from TASK_BACKGROUND_APPLICATION to TASK_UNSPECIFIED. I don't know all the ramifications, but at least the patch is not a no-op, and it makes WKTR more like DRT.
Comment 2 Daniel Bates 2015-04-28 09:15:51 PDT
Comment on attachment 251808 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251808&action=review

This looks sane to me.

> Tools/WebKitTestRunner/mac/main.mm:45
> +    static id assertion = [[[NSProcessInfo processInfo] beginActivityWithOptions:options reason:@"DumpRenderTree should not be subject to process suppression"] retain];

DumpRenderTree => WebKitTestRunner
Comment 3 Alexey Proskuryakov 2015-04-28 10:46:25 PDT
Committed r183488.