Bug 144305 - Implement font-synthesis CSS property
Summary: Implement font-synthesis CSS property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2015-04-27 19:16 PDT by Myles C. Maxfield
Modified: 2015-04-28 11:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (28.44 KB, patch)
2015-04-27 20:57 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (33.35 KB, patch)
2015-04-27 21:08 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (33.35 KB, patch)
2015-04-28 11:02 PDT, Myles C. Maxfield 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-04-27 19:16:54 PDT 
Implement font-synthesis CSS property
Comment 1 Myles C. Maxfield 2015-04-27 20:57:22 PDT 
Created attachment 251818 [details]
Patch
Comment 2 Myles C. Maxfield 2015-04-27 20:58:20 PDT 
<rdar://problem/20692791>
Comment 3 Myles C. Maxfield 2015-04-27 21:08:55 PDT 
Created attachment 251819 [details]
Patch
Comment 4 Jon Lee 2015-04-27 23:37:30 PDT 
Comment on attachment 251819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251819&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:698
> +    bool syntheticOblique = (fontDescription.fontSynthesis & FontSynthesisStyle) && (traits & kCTFontTraitItalic) && !(actualTraits & kCTFontTraitItalic) && !isAppleColorEmoji;

Missing ()
Comment 5 Myles C. Maxfield 2015-04-28 11:02:35 PDT 
Created attachment 251863 [details]
Patch
Comment 6 Andreas Kling 2015-04-28 11:25:15 PDT 
Comment on attachment 251863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251863&action=review

r=me, looks good.

> Source/WebCore/css/StyleBuilderConverter.h:1224
> +    for (CSSValue& i : downcast<CSSValueList>(value)) {

'i' is kind of a weird name for a CSSValue& :)
Comment 7 Myles C. Maxfield 2015-04-28 11:38:14 PDT 
Committed r183494: <http://trac.webkit.org/changeset/183494>