Bug 144299 - PDF action menu fixes
Summary: PDF action menu fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 144307
  Show dependency tree / graph
 
Reported: 2015-04-27 17:52 PDT by Brent Fulgham
Modified: 2015-04-27 19:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.71 KB, patch)
2015-04-27 17:58 PDT, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-04-27 17:52:58 PDT 
After playing with the recent PDF updates, we noticed two problems:

1. The TextIdentifier (yellow highlights) shown when displaying a definition for a word were slightly offset.
2. Zooming out the PDF so that multiple pages were shown in the same WebView caused improper display of the dictionary overlay.
Comment 1 Brent Fulgham 2015-04-27 17:53:38 PDT 
<rdar://problem/20702215>
Comment 2 Brent Fulgham 2015-04-27 17:58:47 PDT 
Created attachment 251799 [details]
Patch
Comment 3 Tim Horton 2015-04-27 18:26:57 PDT 
Comment on attachment 251799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251799&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:625
> +    // Based on TextIndicator implementation:
> +    CGFloat verticalMargin = 2.5;
> +    CGFloat horizontalMargin = 0.5;

We should (separately) figure out a way to make this not be copied into clients who aren't TextIndicator
Comment 4 Brent Fulgham 2015-04-27 19:44:50 PDT 
Committed r183447: <http://trac.webkit.org/changeset/183447>