Bug 144297 – Web Inspector: Add new tab button to make it easy to bring a closed tab back

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

The tab bar should have a new tab button.

[Timothy Hatcher]

Created attachment 251792 [details]
Patch

[Timothy Hatcher]

Created attachment 251793 [details]
Screenshot of New Tab View

[Timothy Hatcher]

Comment on attachment 251792 [details]
Patch

I need to tweak this to work with JSContext inspection.

[Timothy Hatcher]

Created attachment 251807 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 251807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251807&action=review

r=me!

> Source/WebInspectorUI/UserInterface/Views/NewTabContentView.css:26
> +
> +

Style: Double newline oops.

> Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js:33
> +    this._allowedNewTabs = [{image: "Images/Elements.svg", title: WebInspector.UIString("Elements"), type: WebInspector.ElementsTabContentView.Type},
> +        {image: "Images/Console.svg", title: WebInspector.UIString("Console"), type: WebInspector.ConsoleTabContentView.Type}];

Style: Would read cleaner on their own lines.

> Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js:58
> +        var boxElement = document.createElement("div");
> +        boxElement.classList.add("box");
> +
> +        var imageElement = document.createElement("img");
> +        imageElement.src = info.image;
> +
> +        var labelElement = document.createElement("label");
> +        labelElement.textContent = info.title;
> +
> +        boxElement.appendChild(imageElement);
> +        tabItemElement.appendChild(boxElement);
> +        tabItemElement.appendChild(labelElement);

Style: I still prefer just inlining the appendChilds, it saves so many lines, and you know the element is always inserted. Exceptions are "this.element.appendChild".

[Timothy Hatcher]

Comment on attachment 251807 [details]
Patch

https://trac.webkit.org/r183468