WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144294
fast/text/ruby-justification-flush.html fails on safari-600.6-branch
https://bugs.webkit.org/show_bug.cgi?id=144294
Summary
fast/text/ruby-justification-flush.html fails on safari-600.6-branch
Andy Estes
Reported
2015-04-27 17:04:05 PDT
fast/text/ruby-justification-flush.html has failed on safari-600.6-branch after it was introduced by merging
r180278
in
http://trac.webkit.org/changeset/180428
. The test says that it fails if the two black squares are not vertically aligned, which they are not.
Attachments
ruby-justification-flush-diff
(26.26 KB, application/x-webarchive)
2015-04-27 17:07 PDT
,
Andy Estes
no flags
Details
Patch
(3.96 KB, patch)
2015-04-28 14:46 PDT
,
Myles C. Maxfield
aestes
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2015-04-27 17:07:48 PDT
Created
attachment 251789
[details]
ruby-justification-flush-diff
Andy Estes
Comment 2
2015-04-27 18:15:06 PDT
Marked as ImageOnlyFailure in
http://trac.webkit.org/changeset/183437
Myles C. Maxfield
Comment 3
2015-04-28 14:46:37 PDT
Created
attachment 251889
[details]
Patch
Andy Estes
Comment 4
2015-04-28 15:30:17 PDT
Comment on
attachment 251889
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=251889&action=review
r=me if you remove the code change. Thanks!
> Source/WebCore/rendering/RenderBlockLineLayout.cpp:767 > - opportunitiesInRun = Font::expansionOpportunityCount(renderText.characters8() + r->m_start, r->m_stop - r->m_start, r->box()->direction(), isAfterExpansion); > + opportunitiesInRun = Font::expansionOpportunityCount(renderText.characters8(), renderText.textLength(), r->box()->direction(), isAfterExpansion); > else > - opportunitiesInRun = Font::expansionOpportunityCount(renderText.characters16() + r->m_start, r->m_stop - r->m_start, r->box()->direction(), isAfterExpansion); > + opportunitiesInRun = Font::expansionOpportunityCount(renderText.characters16(), renderText.textLength(), r->box()->direction(), isAfterExpansion);
I'd create a separate bug for this, since it isn't necessary to fix the layout test, and we're not yet sure whether we want it in safari-600.6-branch.
Andy Estes
Comment 5
2015-04-28 15:43:29 PDT
Does this test need updating on trunk, too?
Myles C. Maxfield
Comment 6
2015-04-28 19:04:50 PDT
(In reply to
comment #5
)
> Does this test need updating on trunk, too?
Nope! This ruby stuff is pretty different on trunk.
Myles C. Maxfield
Comment 7
2015-04-29 09:17:11 PDT
http://trac.webkit.org/changeset/183549
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug