Bug 144279 - Pages encoded with "cp949" are garbled
Summary: Pages encoded with "cp949" are garbled
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-27 14:52 PDT by Myles C. Maxfield
Modified: 2015-04-27 15:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2015-04-27 14:53 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-04-27 14:52:44 PDT 
Pages encoded with "cp949" are garbled
Comment 1 Myles C. Maxfield 2015-04-27 14:53:47 PDT 
Created attachment 251778 [details]
Patch
Comment 2 Myles C. Maxfield 2015-04-27 14:54:47 PDT 
<rdar://problem/16179744>
Comment 3 Alexey Proskuryakov 2015-04-27 15:11:32 PDT 
Comment on attachment 251778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251778&action=review

> Source/WebCore/platform/text/TextCodecICU.cpp:178
> +    // CFStringConvertEncodingToIANACharSetName(kCFStringEncodingDOSKorean) returns "cp949" instead of "windows-949"
> +    registrar("cp949", "windows-949");

This change adds support for this alias to web content, which looks like the wrong things to do. Firefox and Chrome don't support it (haven't checked IE), and it's not part of the new standard <https://encoding.spec.whatwg.org>. The only registered alias for cp949 is in Java, and it uses a different codec.

What is the user observable issue that you are fixing? We probably need to fix it at a different level.

There is already one workaround for this CFString behavior in defaultTextEncodingNameForSystemLanguage() function.
Comment 4 Alexey Proskuryakov 2015-04-27 15:13:46 PDT 
Found the description in Radar, I think that we shouldn't do anything here.