RESOLVED FIXED 144277
Reduce allocations and memory usage when compiling content extensions. 
https://bugs.webkit.org/show_bug.cgi?id=144277
Summary Reduce allocations and memory usage when compiling content extensions.
Alex Christensen
Reported 2015-04-27 14:20:34 PDT
The BitVector in Term always has capacity of 128, so it always allocates 16 bytes in addition to a pointer to the allocated buffer and additional malloc overhead. Let's just have the 16 bytes.
Attachments
Patch (7.20 KB, patch)
2015-04-27 14:22 PDT, Alex Christensen 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-04-27 14:22:24 PDT
Created attachment 251776 [details] Patch
Benjamin Poulain
Comment 2 2015-04-27 14:46:08 PDT
Comment on attachment 251776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251776&action=review Can you remove the #include <BitVector>? > Source/WebCore/contentextensions/Term.h:131 > + void set(unsigned character) unsigned -> UChar? > Source/WebCore/contentextensions/Term.h:137 > + bool get(unsigned character) const ditto.
Alex Christensen
Comment 3 2015-04-27 15:36:38 PDT
http://trac.webkit.org/changeset/183433
Note You need to log in before you can comment on or make changes to this bug.