Bug 144271 - WirelessTargetPicker should not be visible unless a file is playable
Summary: WirelessTargetPicker should not be visible unless a file is playable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-27 11:18 PDT by Eric Carlson
Modified: 2015-05-04 11:11 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch. (1.90 KB, patch)
2015-04-27 11:24 PDT, Eric Carlson 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (2.61 KB, patch)
2015-04-27 12:39 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-04-27 11:18:05 PDT 
Don't show the picker button until we know a file can be played.
Comment 1 Eric Carlson 2015-04-27 11:23:06 PDT 
<rdar://problem/20712003>
Comment 2 Eric Carlson 2015-04-27 11:24:59 PDT 
Created attachment 251761 [details]
Proposed patch.
Comment 3 Jer Noble 2015-04-27 11:29:59 PDT 
Comment on attachment 251761 [details]
Proposed patch.

Nit: it'd be nice if we could pull out the logic in updateStatusDisplay() into something like "isPlayable()", but this is fine as-is.
Comment 4 Eric Carlson 2015-04-27 12:39:57 PDT 
Created attachment 251770 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2015-04-27 13:34:29 PDT 
Comment on attachment 251770 [details]
Patch for landing.

Clearing flags on attachment: 251770

Committed r183417: <http://trac.webkit.org/changeset/183417>