Bug 144268 - LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code
Summary: LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionCheck...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-27 10:53 PDT by Saam Barati
Modified: 2015-06-16 11:35 PDT (History)
7 users (show)

See Also:

Attachments
patch (1.91 KB, patch)
2015-06-15 18:35 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-04-27 10:53:25 PDT 
The call to loadVariable(.) both for 32bit and 64bit seems unnecessary. 
It grabs a value that is immediately overwritten by a call to getGlobalVar(). 
It should be safe to just delete these calls.
Comment 1 Saam Barati 2015-06-15 18:35:31 PDT 
Created attachment 254916 [details]
patch

Let's see what EWS thinks.
Running tests locally, too.
Comment 2 WebKit Commit Bot 2015-06-16 11:35:04 PDT 
Comment on attachment 254916 [details]
patch

Clearing flags on attachment: 254916

Committed r185596: <http://trac.webkit.org/changeset/185596>
Comment 3 WebKit Commit Bot 2015-06-16 11:35:07 PDT 
All reviewed patches have been landed.  Closing bug.