Bug 144267 - REGRESSION(r182879): Images and video can no longer be downloaded
Summary: REGRESSION(r182879): Images and video can no longer be downloaded
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on: 143794
  Show dependency treegraph
Reported: 2015-04-27 10:41 PDT by Brent Fulgham
Modified: 2015-04-27 11:39 PDT (History)
2 users (show)

See Also:

Patch (4.17 KB, patch)
2015-04-27 10:46 PDT, Brent Fulgham
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-04-27 10:41:40 PDT
While working on Bug 143794, I broke the ability to download image and media content (see <http://trac.webkit.org/changeset/182879>) because I enable the download state on whether the link protocol is type 'file'.

Instead, I should have been checking for NOT file.
Comment 1 Brent Fulgham 2015-04-27 10:45:24 PDT
Comment 2 Brent Fulgham 2015-04-27 10:46:14 PDT
Created attachment 251757 [details]
Comment 3 Simon Fraser (smfr) 2015-04-27 10:50:19 PDT
Comment on attachment 251757 [details]

Is this not testable? Also sad that we have the same code in 4 places. Can you at least reduce that to 2?
Comment 4 Brent Fulgham 2015-04-27 11:38:11 PDT
Added tests to TestWebKITAPI while landing.
Comment 5 Brent Fulgham 2015-04-27 11:39:40 PDT
Committed r183403: <http://trac.webkit.org/changeset/183403>