Bug 144255 - Fix the !ENABLE(CSS_GRID_LAYOUT) build after r183370
Summary: Fix the !ENABLE(CSS_GRID_LAYOUT) build after r183370
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-27 02:21 PDT by Csaba Osztrogonác
Modified: 2015-04-27 04:12 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2015-04-27 02:26 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-04-27 02:21:59 PDT
build log:
../../Source/WebCore/rendering/RenderBox.cpp: In member function 'virtual void WebCore::RenderBox::computeLogicalHeight(WebCore::LayoutUnit, WebCore::LayoutUnit, WebCore::RenderBox::LogicalExtentComputedValues&) const':
../../Source/WebCore/rendering/RenderBox.cpp:2715:109: error: 'class WebCore::RenderElement' has no member named 'isRenderGrid'
ninja: build stopped: subcommand failed.

Fix is coming.
Comment 1 Csaba Osztrogonác 2015-04-27 02:26:45 PDT
Created attachment 251731 [details]
Patch
Comment 2 Javier Fernandez 2015-04-27 02:52:31 PDT
Wow, I totally forgot about the flag. Sorry about it, the patch indeed fixes the bug.
Comment 3 WebKit Commit Bot 2015-04-27 04:12:02 PDT
Comment on attachment 251731 [details]
Patch

Clearing flags on attachment: 251731

Committed r183394: <http://trac.webkit.org/changeset/183394>
Comment 4 WebKit Commit Bot 2015-04-27 04:12:07 PDT
All reviewed patches have been landed.  Closing bug.