Bug 144253 – Map#entries and Map#keys error for non-Maps is swapped

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jordan Harband]

Map.prototype.entries.call({}) gives an error about a "key iterator", and Map.prototype.keys.call({}) gives an error about an "entry iterator".

[Jordan Harband]

Created attachment 251729 [details]
Patch

[Joseph Pecoraro]

Good fix. Can we have a test for these?

  var nonMapObject = {};
  Map.prototype.entries.call(nonMapObject);

[Jordan Harband]

(In reply to comment #2)
> Good fix. Can we have a test for these?
> 
>   var nonMapObject = {};
>   Map.prototype.entries.call(nonMapObject);

Sure, I'll do that in a followup. Where would you recommend I create them? It looks like `Source/JavaScriptCore/tests/stress/iterators-other-receivers` might be a good filename?

[WebKit Commit Bot]

Comment on attachment 251729 [details]
Patch

Clearing flags on attachment: 251729

Committed r183402: <http://trac.webkit.org/changeset/183402>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

(In reply to comment #3)
> (In reply to comment #2)
> > Good fix. Can we have a test for these?
> > 
> >   var nonMapObject = {};
> >   Map.prototype.entries.call(nonMapObject);
> 
> Sure, I'll do that in a followup. Where would you recommend I create them?
> It looks like `Source/JavaScriptCore/tests/stress/iterators-other-receivers`
> might be a good filename?

Yeah, that sounds fine. Feel free to CC me!