Bug 144244 - Class body ending with a semicolon throws a SyntaxError
Summary: Class body ending with a semicolon throws a SyntaxError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency tree / graph
 
Reported: 2015-04-26 18:43 PDT by Ryosuke Niwa
Modified: 2015-04-27 03:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.52 KB, patch)
2015-04-26 20:21 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-04-26 18:43:46 PDT 
class A { ; } or class A { foo() {}; } results in a syntax error but it shoulnd't.
Comment 1 Ryosuke Niwa 2015-04-26 20:21:50 PDT 
Created attachment 251720 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-26 21:21:45 PDT 
Comment on attachment 251720 [details]
Patch

Clearing flags on attachment: 251720

Committed r183383: <http://trac.webkit.org/changeset/183383>
Comment 3 WebKit Commit Bot 2015-04-26 21:21:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Gyuyoung Kim 2015-04-26 22:03:54 PDT 
Committed r183384: <http://trac.webkit.org/changeset/183384>
Comment 5 Gyuyoung Kim 2015-04-26 22:12:47 PDT 
(In reply to comment #4)
> Committed r183384: <http://trac.webkit.org/changeset/183384>

I'm so sorry. My gardening patch messed up ChangeLog.
Comment 6 Alexey Proskuryakov 2015-04-26 22:56:33 PDT 
This test asserts every time: https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r183383%20(3800)/js/class-syntax-semicolon-crash-log.txt

Ryosuke, are you available to fix this now?
Comment 7 Ryosuke Niwa 2015-04-27 02:57:25 PDT 
Oh oops, let me look into it.
Comment 8 Ryosuke Niwa 2015-04-27 03:10:10 PDT 
Oh it looks like this new test uncovered an existing bug in the code.
Comment 9 Ryosuke Niwa 2015-04-27 03:14:52 PDT 
Added a test expectation in http://trac.webkit.org/changeset/183391. Will investigate the assertion failure in webkit.org/b/144258