Bug 144243 - Getter or setter method named "prototype" or "constructor" should throw SyntaxError
Summary: Getter or setter method named "prototype" or "constructor" should throw Synta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency tree / graph
 
Reported: 2015-04-26 17:47 PDT by Ryosuke Niwa
Modified: 2015-04-26 21:19 PDT (History)
7 users (show)

See Also:

Attachments
Fixes the bug (11.60 KB, patch)
2015-04-26 18:27 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-04-26 17:47:34 PDT 
We shouldn't allow getter or setter (either instance and static) method of name "prototype" or "constructor".
Comment 1 Ryosuke Niwa 2015-04-26 18:27:33 PDT 
Created attachment 251716 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2015-04-26 20:32:12 PDT 
Comment on attachment 251716 [details]
Fixes the bug

Thanks for the review!
Comment 3 WebKit Commit Bot 2015-04-26 21:19:31 PDT 
Comment on attachment 251716 [details]
Fixes the bug

Clearing flags on attachment: 251716

Committed r183382: <http://trac.webkit.org/changeset/183382>
Comment 4 WebKit Commit Bot 2015-04-26 21:19:39 PDT 
All reviewed patches have been landed.  Closing bug.