Bug 144239 - Web Inspector: Don't use treeElement.revealAndSelect when showing a default content view
Summary: Web Inspector: Don't use treeElement.revealAndSelect when showing a default c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-04-26 16:24 PDT by Timothy Hatcher
Modified: 2015-04-26 18:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.40 KB, patch)
2015-04-26 16:26 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-26 16:24:39 PDT 
Using revealAndSelect will end up calling WebInspector.showRepresentedObject. That is not bad is most cases, but if the select tab supports the same represented object, it can end up showing the content view in the wrong tab.
Comment 1 Timothy Hatcher 2015-04-26 16:26:23 PDT 
Created attachment 251712 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-26 18:25:49 PDT 
Comment on attachment 251712 [details]
Patch

Clearing flags on attachment: 251712

Committed r183375: <http://trac.webkit.org/changeset/183375>
Comment 3 WebKit Commit Bot 2015-04-26 18:25:53 PDT 
All reviewed patches have been landed.  Closing bug.