Bug 144237 - REGRESSION (r174283): disabled default buttons use impossible-to-read white text on Mac
Summary: REGRESSION (r174283): disabled default buttons use impossible-to-read white t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-26 15:47 PDT by Darin Adler
Modified: 2015-04-26 19:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.61 KB, patch)
2015-04-26 15:50 PDT, Darin Adler
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-04-26 15:47:38 PDT
REGRESSION (r174283): disabled default buttons use impossible-to-read white text on Mac
Comment 1 Darin Adler 2015-04-26 15:50:57 PDT
Created attachment 251711 [details]
Patch
Comment 2 Darin Adler 2015-04-26 15:51:32 PDT
<rdar://problem/19523555>
Comment 3 Simon Fraser (smfr) 2015-04-26 18:05:10 PDT
Comment on attachment 251711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251711&action=review

> Source/WebCore/rendering/RenderTheme.cpp:180
> +        // Special style that tells enabled default in active windows to use the ActiveButtonText color.

enabled default *button*?
Comment 4 mitz 2015-04-26 18:06:27 PDT
Comment on attachment 251711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251711&action=review

> Source/WebCore/rendering/RenderTheme.cpp:180
> +        // Special style that tells enabled default in active windows to use the ActiveButtonText color.

Missing word before “in”.
Comment 5 Darin Adler 2015-04-26 19:05:22 PDT
Committed r183378: <http://trac.webkit.org/changeset/183378>