Bug 144219 - [WK2] API::URL creation functions should return Ref<>
Summary: [WK2] API::URL creation functions should return Ref<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-26 06:37 PDT by Zan Dobersek
Modified: 2015-04-27 13:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.84 KB, patch)
2015-04-26 06:38 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (6.85 KB, patch)
2015-04-26 07:02 PDT, Zan Dobersek 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2015-04-26 06:37:27 PDT 
API::URL creation functions should return Ref<>
Comment 1 Zan Dobersek 2015-04-26 06:38:37 PDT 
Created attachment 251683 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-26 06:39:45 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2015-04-26 07:02:59 PDT 
Created attachment 251690 [details]
Patch
Comment 4 Darin Adler 2015-04-26 11:58:26 PDT 
Comment on attachment 251690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251690&action=review

> Source/WebKit2/Shared/API/c/WKSharedAPICast.h:177
>          return 0;

nullptr
Comment 5 Zan Dobersek 2015-04-27 13:10:55 PDT 
Committed r183410: <http://trac.webkit.org/changeset/183410>