Bug 144208 - Web Inspector: Tabs should have Context Menus
Summary: Web Inspector: Tabs should have Context Menus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-25 20:04 PDT by Joseph Pecoraro
Modified: 2015-05-29 11:46 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.06 KB, patch)
2015-05-28 15:19 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-25 20:04:45 PDT 
* SUMMARY
Inspector Tabs should have Context Menus.

Right now it seems it would be logical to have "Close Tab" for the closable tabs. Anything else?
Comment 1 Radar WebKit Bug Importer 2015-04-25 20:05:01 PDT 
<rdar://problem/20700511>
Comment 2 Joseph Pecoraro 2015-05-28 15:19:40 PDT 
Created attachment 253870 [details]
[PATCH] Proposed Fix

These menu items match other OS X applications like Safari and Terminal.
Comment 3 Timothy Hatcher 2015-05-28 16:08:14 PDT 
Comment on attachment 253870 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253870&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBarItem.js:202
> +        contextMenu.appendItem(WebInspector.UIString("Close Other Tabs"), closeOtherTabs.bind(this), !hasOtherNonPinnedTabs);

Not super convinced this is useful for us.
Comment 4 Joseph Pecoraro 2015-05-28 16:18:26 PDT 
(In reply to comment #3)
> Comment on attachment 253870 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253870&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TabBarItem.js:202
> > +        contextMenu.appendItem(WebInspector.UIString("Close Other Tabs"), closeOtherTabs.bind(this), !hasOtherNonPinnedTabs);
> 
> Not super convinced this is useful for us.

Yeah... I just added it to be consistent with everything else I could find on the system, which all had it.
Comment 5 Joseph Pecoraro 2015-05-29 11:46:27 PDT 
http://trac.webkit.org/changeset/184996