Bug 144208 – Web Inspector: Tabs should have Context Menus

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Inspector Tabs should have Context Menus.

Right now it seems it would be logical to have "Close Tab" for the closable tabs. Anything else?

[Radar WebKit Bug Importer]

<rdar://problem/20700511>

[Joseph Pecoraro]

Created attachment 253870 [details]
[PATCH] Proposed Fix

These menu items match other OS X applications like Safari and Terminal.

[Timothy Hatcher]

Comment on attachment 253870 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253870&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBarItem.js:202
> +        contextMenu.appendItem(WebInspector.UIString("Close Other Tabs"), closeOtherTabs.bind(this), !hasOtherNonPinnedTabs);

Not super convinced this is useful for us.

[Joseph Pecoraro]

(In reply to comment #3)
> Comment on attachment 253870 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253870&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TabBarItem.js:202
> > +        contextMenu.appendItem(WebInspector.UIString("Close Other Tabs"), closeOtherTabs.bind(this), !hasOtherNonPinnedTabs);
> 
> Not super convinced this is useful for us.

Yeah... I just added it to be consistent with everything else I could find on the system, which all had it.

[Joseph Pecoraro]

http://trac.webkit.org/changeset/184996