Bug 144197 - Web Inspector: Split search from ResourceSidebarPanel into a Search tab and sidebar
Summary: Web Inspector: Split search from ResourceSidebarPanel into a Search tab and s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-04-25 15:45 PDT by Timothy Hatcher
Modified: 2015-04-25 18:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (67.71 KB, patch)
2015-04-25 15:46 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Screenshot (705.69 KB, image/png)
2015-04-25 15:48 PDT, Timothy Hatcher 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-25 15:45:24 PDT 
Search results should be their own tab.
Comment 1 Timothy Hatcher 2015-04-25 15:46:29 PDT 
Created attachment 251649 [details]
Patch
Comment 2 Timothy Hatcher 2015-04-25 15:48:06 PDT 
Created attachment 251650 [details]
Screenshot
Comment 3 Joseph Pecoraro 2015-04-25 17:36:36 PDT 
(In reply to comment #2)
> Created attachment 251650 [details]
> Screenshot

I wonder if the Search placeholder should somehow be centered. That is the case on my Yosemite Mail.app's search field. Potential for a future polish patch.
Comment 4 Joseph Pecoraro 2015-04-25 17:44:00 PDT 
Comment on attachment 251649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251649&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SearchBar.js:28
> +    constructor(identifier, placeholder, delegate, supressIncremental)

Typo: "supress" => "suppress"

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:45
> +        this._inputElement.setAttribute("placeholder", WebInspector.UIString("Search Resource Content"));

I think this can just be a property and not a "setAttribute". Probably the others as well, but I'm not as certain for those.
Comment 5 Timothy Hatcher 2015-04-25 18:36:03 PDT 
r183322 – r183342

http://trac.webkit.org/log/?revs=183322-183342