Per https://people.mozilla.org/~jorendorff/es6-draft.html#sec-map.prototype.foreach step 7.a.i., the callback should be called with three arguments. Currently, it's called with only two.
Created attachment 251616 [details] Patch
Comment on attachment 251616 [details] Patch Attachment 251616 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4626865851465728 New failing tests: js/map-foreach-calls-back-with-right-args.html
Created attachment 251618 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 251616 [details] Patch Attachment 251616 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5476904303853568 New failing tests: js/map-foreach-calls-back-with-right-args.html
Created attachment 251621 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 251616 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251616&action=review > LayoutTests/js/script-tests/map-foreach-calls-back-with-right-args.js:11 > + print(value === 'value' ? 'PASS value is "value"' : 'FAIL value is ' + value); > + print(key === 'key' ? 'PASS key is "key"' : 'FAIL key is ' + key); > + print(map === m ? 'PASS map arg is map' : 'FAIL map arg is ' + map); > + print(this === receiver ? 'PASS "this" is "receiver"' : 'FAIL "this" is ' + this); These are wrong. See the comment I added to the Set version of this patch for a tip on how to do this.
Created attachment 251707 [details] Patch
Comment on attachment 251707 [details] Patch Rejecting attachment 251707 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 251707, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6752778026221568
Comment on attachment 251707 [details] Patch I forgot to set the review bit on this one first
Comment on attachment 251707 [details] Patch Clearing flags on attachment: 251707 Committed r183374: <http://trac.webkit.org/changeset/183374>
All reviewed patches have been landed. Closing bug.