Bug 144180 – Implement parsing support for font-synthesis CSS property

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Implement parsing support for font-synthesis CSS property

[Myles C. Maxfield]

Created attachment 251603 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/20692791>

[Myles C. Maxfield]

Comment on attachment 251603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251603&action=review

> LayoutTests/fast/css3-text/font-synthesis-parse.html:93
> +    stylesheet.insertRule("#p { font-synthesis: weight style }", 0);

Add a test for duplicate valid values

[Tim Horton]

Comment on attachment 251603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251603&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=144180

please put the radar here

> Source/WebCore/ChangeLog:15
> +        * css/CSSComputedStyleDeclaration.cpp:

more comments!

> Source/WebCore/css/StyleBuilderCustom.h:1386
> +    bool encounteredStyle = false;

Flags would make this look less silly too

> Source/WebCore/rendering/style/RenderStyleConstants.h:423
> +    FontSynthesisWeight = 0x1,
> +    FontSynthesisStyle = 0x2,
> +    FontSynthesisWeightAndStyle = 0x3

This looks ripe for bitflagging, no? Like TextDecoration, below.

[Myles C. Maxfield]

Committed r183304: <http://trac.webkit.org/changeset/183304>