RESOLVED FIXED 144172
TextIndicator for embedded PDFs is slightly offset 
https://bugs.webkit.org/show_bug.cgi?id=144172
Summary TextIndicator for embedded PDFs is slightly offset
Brent Fulgham
Reported 2015-04-24 16:36:51 PDT
The Yellow Highlights (TextIndicators) around the word/phrase selected for dictionary lookup, etc., is slightly offset from the layout in PDF.
Attachments
Patch (5.26 KB, patch)
2015-04-24 16:59 PDT, Brent Fulgham 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-04-24 16:37:24 PDT
<rdar://problem/20691304>
Brent Fulgham
Comment 2 2015-04-24 16:59:49 PDT
Created attachment 251594 [details] Patch
Tim Horton
Comment 3 2015-04-24 17:01:37 PDT
Comment on attachment 251594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251594&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:596 > This function maybe should get a name that isn't about PluginView since it doesn't take one of those anymore.
Brent Fulgham
Comment 4 2015-04-24 17:03:20 PDT
Comment on attachment 251594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251594&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:596 >> > > This function maybe should get a name that isn't about PluginView since it doesn't take one of those anymore. Well, it takes a PDFPlugin. Maybe I should just drop "PluginView" entirely, since the PDFSelection signifies it's PDF-related.
Brent Fulgham
Comment 5 2015-04-24 17:18:00 PDT
Committed r183297: <http://trac.webkit.org/changeset/183297>
Note You need to log in before you can comment on or make changes to this bug.