Bug 144165 - Track a coverage rect through GraphicsLayerCA flushes, use it to mark backing store attached
Summary: Track a coverage rect through GraphicsLayerCA flushes, use it to mark backing...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
: 144163 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-04-24 15:22 PDT by Simon Fraser (smfr)
Modified: 2015-04-24 18:04 PDT (History)
6 users (show)

See Also:


Attachments
Patch (99.29 KB, patch)
2015-04-24 15:46 PDT, Simon Fraser (smfr)
dino: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (784.10 KB, application/zip)
2015-04-24 16:42 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-04-24 15:22:11 PDT
Track a coverage rect through GraphicsLayerCA flushes, use it to mark backing store attached
Comment 1 Simon Fraser (smfr) 2015-04-24 15:46:22 PDT
Created attachment 251580 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-04-24 16:07:33 PDT
*** Bug 144163 has been marked as a duplicate of this bug. ***
Comment 3 Dean Jackson 2015-04-24 16:23:06 PDT
Comment on attachment 251580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251580&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1079
> +    FloatQuad coverageQuad(clipRect);
> +    state.setSecondaryQuad(&coverageQuad);

It's a bit weird that you have to make a local variable for this.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1217
> +            FloatQuad secondaryQuad(clipRectForSelf);
> +            state.setSecondaryQuad(&secondaryQuad);
> +        }

And this.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1245
> +        // FIXME: we need to take reflections into count when determining whether this layer intersects the coverage rect.

Typo: into account

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1249
> +            maskLayer->m_uncommittedChanges |= coverageRectChanged;

you mean CoverageRectChanged not coverageRectChanged. I wonder if you could have tested for this.
Comment 4 Build Bot 2015-04-24 16:42:25 PDT
Comment on attachment 251580 [details]
Patch

Attachment 251580 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6491477047771136

New failing tests:
platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll.html
platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html
platform/mac-wk2/tiled-drawing/use-tiled-drawing.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html
platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div.html
platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html
platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html
platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom.html
platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html
platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-zoomed.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select.html
platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html
platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling.html
platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler.html
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html
platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html
Comment 5 Build Bot 2015-04-24 16:42:29 PDT
Created attachment 251591 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Simon Fraser (smfr) 2015-04-24 18:04:27 PDT
https://trac.webkit.org/r183300
Comment 7 Simon Fraser (smfr) 2015-04-24 18:04:45 PDT
Test fixes in https://trac.webkit.org/r183301