Track a coverage rect through GraphicsLayerCA flushes, use it to mark backing store attached
Created attachment 251580 [details] Patch
*** Bug 144163 has been marked as a duplicate of this bug. ***
Comment on attachment 251580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251580&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1079 > + FloatQuad coverageQuad(clipRect); > + state.setSecondaryQuad(&coverageQuad); It's a bit weird that you have to make a local variable for this. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1217 > + FloatQuad secondaryQuad(clipRectForSelf); > + state.setSecondaryQuad(&secondaryQuad); > + } And this. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1245 > + // FIXME: we need to take reflections into count when determining whether this layer intersects the coverage rect. Typo: into account > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1249 > + maskLayer->m_uncommittedChanges |= coverageRectChanged; you mean CoverageRectChanged not coverageRectChanged. I wonder if you could have tested for this.
Comment on attachment 251580 [details] Patch Attachment 251580 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6491477047771136 New failing tests: platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll.html platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html platform/mac-wk2/tiled-drawing/use-tiled-drawing.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div.html platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom.html platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-zoomed.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select.html platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling.html platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler.html platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html
Created attachment 251591 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
https://trac.webkit.org/r183300
Test fixes in https://trac.webkit.org/r183301