Bug 144162 – WKPDFView does not support password-protected PDFs

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

WKPDFView does not support password-protected PDFs

[Tim Horton]

Created attachment 251576 [details]
Patch

[Tim Horton]

<rdar://problem/18411512>

[David Kilzer (:ddkilzer)]

The initial iOS EWS orange status is due to me updating the EWS to iOS 8.3.  It should retry again.

[Andy Estes]

Comment on attachment 251576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251576&action=review

> Source/WebKit2/Platform/spi/ios/UIKitSPI.h:689
> +@interface UIDocumentPasswordView : UIView <UITextFieldDelegate>
> +
> +- (id)initWithDocumentName:(NSString *)documentName;
> +
> +@property (nonatomic, assign) NSObject<UIDocumentPasswordViewDelegate> *passwordDelegate;
> +@property (nonatomic, readonly) UITextField *passwordField;
> +
> +@end

I believe the convention for these SPI headers is to declare all methods and properties in a category.

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:735
> +    if (![passwordField isEditing])

passwordField.isEditing?

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:742
> +    UIWindow *window = [_scrollView window];

_scrollView.window?

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:755
> +        CGPoint contentOffset = [_scrollView contentOffset];

_scrollView.contentOffset?

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:809
> +    UIAlertAction* defaultAction = [UIAlertAction actionWithTitle:WEB_UI_STRING_KEY("OK", "OK (PDF password failure alert)", "OK button label in PDF password failure alert") style:UIAlertActionStyleDefault handler:^(UIAlertAction *) { }];

Not that it matters here since you don't capture anything, but you could use a lambda instead of a block.

[Andy Estes]

Comment on attachment 251576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251576&action=review

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:801
> +    [[NSNotificationCenter defaultCenter] removeObserver:self name:UIKeyboardDidShowNotification object:nil];

Are you sure that this will always be called before a WKPDFView is deallocated? Should this be done in -dealloc as well?

[Tim Horton]

http://trac.webkit.org/changeset/183293

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> http://trac.webkit.org/changeset/183293

Build fix: <http://trac.webkit.org/changeset/183296>